⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@BYK
Copy link
Member

@BYK BYK commented Jan 9, 2026

Summary

This PR migrates from the deprecated action-prepare-release to the new Craft GitHub Actions.

Changes

  • Migrated .github/workflows/auto-release.yml to Craft reusable workflow

Documentation

See https://getsentry.github.io/craft/github-actions/ for more information.

Closes #18765 (added automatically)

This PR migrates from the deprecated action-prepare-release to the new
Craft GitHub Actions (reusable workflow or composite action).

Changes:
- Migrate .github/workflows/release.yml to Craft reusable workflow
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • (core) Add option to enhance the fetch error message by JPeer264 in #18466
  • (core,node-core) Consolidate bun and node types with ServerRuntimeOptions by JPeer264 in #18734
  • (nextjs) Remove tracing from generation function template by chargome in #18733
  • (tanstackstart-react) Add wrappers for manual instrumentation of servers-side middlewares by nicohrubec in #18680

Build / dependencies / internal 🔧

  • (nextjs) Split withSentryConfig by chargome in #18777
  • (release) Switch from action-prepare-release to Craft by BYK in #18763

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,981 - 8,758 +3%
GET With Sentry 1,771 20% 1,683 +5%
GET With Sentry (error only) 6,097 68% 6,037 +1%
POST Baseline 1,206 - 1,182 +2%
POST With Sentry 595 49% 576 +3%
POST With Sentry (error only) 1,059 88% 1,047 +1%
MYSQL Baseline 3,302 - 3,207 +3%
MYSQL With Sentry 489 15% 407 +20%
MYSQL With Sentry (error only) 2,674 81% 2,615 +2%

View base workflow run

BYK added 2 commits January 9, 2026 23:16
The previous migration incorrectly removed the GitHub App token
authentication step. This commit restores it by switching to the
composite action pattern which preserves the auth flow.
The previous migration incorrectly removed the GitHub App token
authentication step. This commit restores it by switching to the
composite action pattern which preserves the auth flow.
Comment on lines 2 to 9
on:
pull_request:
types:
- closed
branches:
- master

# This workflow tirggers a release when merging a branch with the pattern `prepare-release/VERSION` into master.
workflow_dispatch:
inputs:
version:
description: Version to release (or "auto")
required: false
force:
description: Force a release even when there are release-blockers

This comment was marked as outdated.

Comment on lines 2 to 11
on:
pull_request:
types:
- closed
branches:
- master
workflow_dispatch:
inputs:
version:
description: Version to release (or "auto")
required: false
force:
description: Force a release even when there are release-blockers
required: false
merge_target:

This comment was marked as outdated.

Comment on lines 33 to 41
- name: Prepare release
uses: getsentry/craft@39ee616a6a58dc64797feecb145d66770492b66c # v2
env:
GITHUB_TOKEN: ${{ steps.token.outputs.token }}
with:
version: ${{ inputs.version }}
force: ${{ inputs.force }}
merge_target: ${{ inputs.merge_target }}
craft_config_from_merge_target: 'true'

This comment was marked as outdated.

required: false
merge_target:
description: Target branch to merge into. Uses the default branch as a fallback (optional)
description: Target branch to merge into
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed default value for merge_target input

Medium Severity

The merge_target input previously had default: master but this was removed. When users trigger the release workflow without specifying a merge_target, an empty value will be passed to the Craft action via ${{ inputs.merge_target }}. In contrast, auto-release.yml explicitly passes merge_target: master. If Craft doesn't handle empty merge_target values gracefully, this could cause the release workflow to fail or behave unexpectedly.

Fix in Cursor Fix in Web

- name: Get auth token
id: token
uses: actions/create-github-app-token@29824e69f54612133e76f7eaac726eef6c875baf # v2.2.1
uses: actions/create-github-app-token@29824e69f54612133e76f7eaac726eef6c875baf # v2 # v2 # v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: Are all these version bumps actually related? The version comments are a bit confusing here

required: false
merge_target:
description: Target branch to merge into. Uses the default branch as a fallback (optional)
description: Target branch to merge into
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: How does craft handle this case?

release:
runs-on: ubuntu-24.04
name: 'Release a new version'
runs-on: ubuntu-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: I think pinning to latest would make our CI more brittle here, is this required?

Comment on lines 26 to 29
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6
with:
token: ${{ steps.token.outputs.token }}
fetch-depth: 0

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci(release): Switch from action-prepare-release to Craft

3 participants