Refactor refs to make react 15 happy#208
Open
yury-dymov wants to merge 3 commits intofmoo:masterfrom
yury-dymov:react15-no-ref
Open
Refactor refs to make react 15 happy#208yury-dymov wants to merge 3 commits intofmoo:masterfrom yury-dymov:react15-no-ref
yury-dymov wants to merge 3 commits intofmoo:masterfrom
yury-dymov:react15-no-ref
Conversation
Owner
|
Does the new refs method actively break 0.14? You can npm run test:14 to verify. If so, we'll need to update the peerDependencies and run scripts as well. |
Author
|
@fmoo it doesn't. npm run test:react:14 after merge: |
Owner
|
Oh, it looks like another rev broke a bunch of the tests. I'll follow up on that elsewhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.