Fix: Allow sync to bypass ActorLimit (Issue #951) #965
+168
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When syncing from Cloud, the ActorLimit adapter would prevent syncing actors if the remote had more actors than the local limit allowed. This created an unrecoverable state where users couldn't recover by removing actors in Cloud because sync would fail before removals could process. Add thread-local sync mode to ActorLimit that disables limit enforcement during sync operations. This allows Cloud (the source of truth) to sync all data while still enforcing limits on user-initiated operations. Co-Authored-By: Claude Haiku 4.5 <[email protected]>
Verify that preloading works correctly when using a Sync adapter wrapped with ActorLimit, even when the remote has more actors than the local limit allows. Co-Authored-By: Claude Haiku 4.5 <[email protected]>
- Test incremental sync: 20 actors synced, then 21st added and synced - Test that direct enable operations still enforce limits after sync - Use 10/20 actor ratio to better simulate realistic Cloud scenario Co-Authored-By: Claude Haiku 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When syncing from Cloud, the ActorLimit adapter would prevent syncing actors if the remote had more actors than the local limit allowed, creating an unrecoverable state. This fix adds thread-local sync mode to ActorLimit that disables limit enforcement during sync operations while still enforcing limits on user-initiated operations. Cloud can now sync all data without being blocked by local actor limits.
Test Plan
🤖 Generated with Claude Code