Improve toolbox search indexing for translated block labels #271
+316
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
main/blocklyinit.jsthat constructs a searchabletextfor each toolbox block by collectingtype,keyword(includingblockInfo.full.keyword), field text, dropdown options, and the block’s rendered label viablock.toString()with a translatedmessage0fallback usingBlockly.utils.replaceMessageReferencesandtranslate().Blockly.Workspacewhich is disposed after building the index, and the category’sblockSearcher.indexBlocksis replaced with arebuildSearchIndexfunction so the index can be rebuilt on demand; the search category is exposed atworkspace.flockSearchCategory.main/translation.jsto callworkspace.flockSearchCategory.blockSearcher.indexBlocks()aftersetLanguagerefreshes toolbox and blocks so the search index is retranslated to the active language.Testing
Codex Task