⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Make mode parameter nullable in addOption and addArgument #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n0nag0n merged 2 commits into from
Dec 27, 2025
Merged

Make mode parameter nullable in addOption and addArgument #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cf5f94
Make mode parameter nullable in addOption and addArgument
ycrao Dec 26, 2025
a773921
Merge branch 'master' into master
n0nag0n Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/commands/AbstractBaseCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ protected function setRunwayConfigValue(string $key, $value): void {
*
* @return $this
*/
public function addOption(string $name, $shortcut = null, int $mode = null, string $description = '', $default = null): self {
public function addOption(string $name, $shortcut = null, ?int $mode = null, string $description = '', $default = null): self
{
// Build raw option format Ahc\Cli expects, e.g. "-s, --name" or "--name"
$raw = '';

Expand Down Expand Up @@ -139,7 +140,8 @@ public function addOption(string $name, $shortcut = null, int $mode = null, stri
*
* @return $this
*/
public function addArgument(string $name, int $mode = null, string $description = '', $default = null): self {
public function addArgument(string $name, ?int $mode = null, string $description = '', $default = null): self
{
if ($mode === null) {
$mode = self::OPTIONAL;
}
Expand Down