-
Notifications
You must be signed in to change notification settings - Fork 9
fastapi cloud logs
#132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fastapi cloud logs
#132
Conversation
patrick91
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, I did push a couple of commits, but I was also wondering if we can update the code to be more similar to what we do for the deploy logs (for example using the attempts decorator and adding the stream logs function to or APIClient)?
|
Oh, wow. I completely missed that we had that. That'll be much simpler, will refactor a bit! |
c013021 to
e839475
Compare
patrick91
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Thank you!
Basically built this to test out https://github.com/fastapilabs/cloud/pull/2163 (so we need to wait until that's settled before merging this)
Tested manually via interactive logs and piped to a file.
Screen.Recording.2025-12-17.at.4.07.22.PM.mov