⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@savannahostrowski
Copy link
Member

Basically built this to test out https://github.com/fastapilabs/cloud/pull/2163 (so we need to wait until that's settled before merging this)

Tested manually via interactive logs and piped to a file.

image
Screen.Recording.2025-12-17.at.4.07.22.PM.mov

@savannahostrowski savannahostrowski added the feature New feature or request label Dec 18, 2025
@savannahostrowski savannahostrowski marked this pull request as ready for review January 8, 2026 19:27
Copy link
Collaborator

@patrick91 patrick91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, I did push a couple of commits, but I was also wondering if we can update the code to be more similar to what we do for the deploy logs (for example using the attempts decorator and adding the stream logs function to or APIClient)?

@savannahostrowski
Copy link
Member Author

Oh, wow. I completely missed that we had that. That'll be much simpler, will refactor a bit!

@savannahostrowski savannahostrowski force-pushed the logs_command branch 2 times, most recently from c013021 to e839475 Compare January 9, 2026 17:30
Copy link
Collaborator

@patrick91 patrick91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thank you!

@patrick91 patrick91 merged commit eda6610 into fastapilabs:main Jan 13, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants