fix: support vector of bytes in extract requests #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealbobo
force-pushed
the
support-vector-bytebuf-during-extraction
branch
from
142fb24 to
3837201
Compare
Signed-off-by: Roberto Scolaro <[email protected]>
therealbobo
force-pushed
the
support-vector-bytebuf-during-extraction
branch
from
3837201 to
59fa4c6
Compare
leogr
approved these changes
Dec 17, 2025
|
LGTM label has been added. DetailsGit tree hash: ed3aadd8ed7105a68de72ef418b083eee8216a12 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr, therealbobo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
irozzo-1A
reviewed
Dec 17, 2025
| { | ||
| static_assert(sizeof(typename T::value_type) == 1, | ||
| "Buffer container must hold byte-sized elements"); | ||
| set_value((void*)container.data(), (uint32_t)container.size(), pos, |
Contributor
There was a problem hiding this comment.
This method takes a const reference to a container like a vector, but as we cast to a void pointer we violate the const semantic. I see two solutions:
- Remove
const - Always copy
I suggest not using C-style cast to make the need for the const_cast explicit.
Suggested change
| set_value((void*)container.data(), (uint32_t)container.size(), pos, | |
| set_value(static_cast<void*>(container.data()), static_cast<uint32_t>(container.size()), pos, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
What this PR does / why we need it:
At the moment we lack of an api to push vectors of bytebufs (e.g. a list of PT_IPADDR). This fixes it.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: