⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Bump 'rdoc' dependency, handle 'erb' version constraint with Ruby 3.1 and improve CI bundle cache #3185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stefannibrasil wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −15
Open

Bump 'rdoc' dependency, handle 'erb' version constraint with Ruby 3.1 and improve CI bundle cache #3185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1a8cd2
Cache dependencies using ruby/setup-ruby
stefannibrasil Jan 14, 2026
adb6cc5
Bump 'rdoc' version and handle 'erb' while Ruby 3.1 is still supported
stefannibrasil Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/bench.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,8 @@ jobs:
- uses: actions/checkout@v6
- uses: ruby/setup-ruby@v1
with:
ruby-version: '3.4'
- name: Install dependencies
run: bundle install
ruby-version: '4.0'
bundler-cache: true

- name: Generators
run: RUBYOPT="-W0" bundle exec ruby benchmark/generators.rb
Expand Down
16 changes: 7 additions & 9 deletions .github/workflows/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,20 +21,22 @@ jobs:
lint:
name: RuboCop
runs-on: ubuntu-latest
env:
BUNDLE_WITHOUT: benchmark
steps:
- uses: actions/checkout@v6
- uses: ruby/setup-ruby@v1
with:
ruby-version: '3.4'

- name: Install dependencies
run: bundle install
ruby-version: '4.0'
bundler-cache: true

- name: Run RuboCop
run: bundle exec rake rubocop
test:
name: Ruby ${{ matrix.ruby }}
runs-on: ubuntu-latest
env:
BUNDLE_WITHOUT: benchmark
strategy:
fail-fast: false # don't fail all matrix builds if one fails
matrix:
Expand All @@ -52,11 +54,7 @@ jobs:
- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}

- name: Install dependencies
run: |
bundle config --without benchmark
bundle install
bundler-cache: true

- name: Run tests
run: bundle exec rake test
3 changes: 3 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ gem 'test-unit', '3.7.7'
gem 'timecop', '0.9.10'
gem 'yard', '0.9.38'

# TODO: remove when Ruby 3.1 is no longer supported
gem 'erb', '~> 4.0.4'

group :benchmark do
gem 'benchmark'
gem 'benchmark-ips'
Expand Down
9 changes: 6 additions & 3 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,13 @@ GEM
ast (2.4.3)
benchmark (0.5.0)
benchmark-ips (2.14.0)
cgi (0.5.1)
coderay (1.1.3)
concurrent-ruby (1.3.6)
date (3.5.1)
docile (1.4.1)
erb (6.0.1)
erb (4.0.4)
cgi (>= 0.3.3)
i18n (1.14.8)
concurrent-ruby (~> 1.0)
io-console (0.8.2)
Expand Down Expand Up @@ -46,7 +48,7 @@ GEM
racc (1.8.1)
rainbow (3.1.1)
rake (13.3.1)
rdoc (7.0.3)
rdoc (7.1.0)
erb
psych (>= 4.0.0)
tsort
Expand Down Expand Up @@ -92,12 +94,13 @@ GEM
yard (0.9.38)

PLATFORMS
arm64-darwin-22
arm64-darwin
Copy link
Contributor Author

@stefannibrasil stefannibrasil Jan 14, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the specific version that is being removed, I was getting a diff every time I ran bundle install.

x86_64-linux

DEPENDENCIES
benchmark
benchmark-ips
erb (~> 4.0.4)
faker!
irb
minitest (= 5.27.0)
Expand Down