⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Fix logspam on CxxPlatform when metro isn't running #55146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javache wants to merge 2 commits into from
+9 −3
Closed

Fix logspam on CxxPlatform when metro isn't running #55146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26bfb9a
Fix Hermes opt mode for local mac runs (#55138)
javache Jan 13, 2026
d6512a5
Fix logspam on CxxPlatform when metro isn't running
javache Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...ative/ReactCxxPlatform/react/devsupport/inspector/InspectorPackagerConnectionDelegate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ InspectorPackagerConnectionDelegate::WebSocket::WebSocket(
if (success) {
strongDelegate->didOpen();
} else {
strongDelegate->didFailWithError(std::nullopt, message);
// Assume the server is not running, and suppress an error log
strongDelegate->didFailWithError(ECONNREFUSED, message);
}
}
});
Expand Down
9 changes: 7 additions & 2 deletions private/react-native-fantom/runner/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ export function getHermesCompilerTarget(variant: HermesVariant): string {
export function getBuckModesForPlatform(
enableRelease: boolean = false,
): $ReadOnlyArray<string> {
let mode = enableRelease ? 'opt' : 'dev';
let modes = ['@//xplat/mode/react-native/granite'];
if (enableRelease) {
modes.push('@//xplat/mode/hermes/opt');
}

let mode = enableRelease ? 'opt' : 'dev';
if (enableRelease) {
if (EnvironmentOptions.enableASAN || EnvironmentOptions.enableTSAN) {
printConsoleLog({
Expand Down Expand Up @@ -101,7 +105,8 @@ export function getBuckModesForPlatform(
throw new Error(`Unsupported platform: ${os.platform()}`);
}

return ['@//xplat/mode/react-native/granite', osPlatform];
modes.push(osPlatform);
return modes;
}

// TODO: T240293839 Remove when we get rid of RN_USE_ANIMATION_BACKEND preprocessor flag
Expand Down
Loading