Refactor try/catch blocks to use mixed type annotations #53938
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating diff in D82304028. |
facebook-github-bot
added
fb-exported
meta-exported
p: Facebook
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 25, 2025
Summary: - Add `: mixed` annotations to all catch parameters in React Native JS files - Create toError utility for converting mixed values to Error instances - Create toExtendedError utility for LogBox-specific ExtendedError conversion - Fix Flow type compatibility issues with proper error handling - Resolve ESLint import order warnings Reviewed By: andrewdacenko Differential Revision: D82304028
…3938) Summary: Changelog: [internal] - Add `: unknown` annotations to all catch parameters in React Native JS files - Create toError utility for converting mixed values to Error instances - Create toExtendedError utility for LogBox-specific ExtendedError conversion - Fix Flow type compatibility issues with proper error handling - Resolve ESLint import order warnings Reviewed By: andrewdacenko Differential Revision: D82304028
rubennorte
force-pushed
the
export-D82304028
branch
from
6661f8d to
1bcd97c
Compare
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D82304028. |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 13, 2026
…3938) Summary: Changelog: [internal] - Add `: unknown` annotations to all catch parameters in React Native JS files - Create toError utility for converting mixed values to Error instances - Create toExtendedError utility for LogBox-specific ExtendedError conversion - Fix Flow type compatibility issues with proper error handling - Resolve ESLint import order warnings Reviewed By: andrewdacenko Differential Revision: D82304028
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 13, 2026
…3938) Summary: Changelog: [internal] - Add `: unknown` annotations to all catch parameters in React Native JS files - Create toError utility for converting mixed values to Error instances - Create toExtendedError utility for LogBox-specific ExtendedError conversion - Fix Flow type compatibility issues with proper error handling - Resolve ESLint import order warnings Reviewed By: andrewdacenko Differential Revision: D82304028
Collaborator
|
This pull request was successfully merged by @rubennorte in 0be68b3 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
: mixedannotations to all catch parameters in React Native JS filesReviewed By: andrewdacenko
Differential Revision: D82304028