Add SWIP: Fork Digest and BzzAddress Encoding#84
Open
mfw78 wants to merge 3 commits intoethersphere:masterfrom
Open
Add SWIP: Fork Digest and BzzAddress Encoding#84mfw78 wants to merge 3 commits intoethersphere:masterfrom
mfw78 wants to merge 3 commits intoethersphere:masterfrom
Conversation
Introduce a fork digest mechanism that enables nodes to identify compatible peers during network upgrades via the handshake and Hive peer gossip. Key features: - 4-byte fork digest derived from genesis hash and fork version - Handshake integration for connection-time compatibility checks - Hive protocol integration for fork-aware peer gossip filtering - Updated BzzAddress signature scheme (v1) removing redundant prefix - Two-release migration path for backwards compatibility
Extend the fork digest SWIP to also clean up underlay encoding: - Change `bytes underlay` to `repeated bytes underlays` in protobuf - Remove custom 0x99 prefix and varint length encoding - Signature v1 uses simple concatenation of multiaddr bytes - Add rationale for why no additional framing is needed - Add test cases for signature verification and underlay encoding This separates wire encoding (protobuf) from signature construction (application logic) and simplifies implementations.
mfw78
changed the title
Member
|
@mfw78 thank you for this! i feel like there are two issues here. i think it would be good to separate them for clarity of discussion 😌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This SWIP introduces a fork digest mechanism for network upgrade coordination and cleans up the BzzAddress underlay encoding by replacing custom serialization with idiomatic protobuf.
Key Features
Fork Digest
BzzAddress Encoding
repeated bytes underlaysreplacesbytes underlaywith custom encoding0x99magic prefix or varint length encodingSignature Scheme (v1)
"bee-handshake-"prefix (EIP-191 already provides domain separation)Migration Path
Feedback Requested
The exact composition of the genesis hash requires further discussion. Candidates for inclusion:
network_id(required)genesis_timestamp