fix(api-structure-previews): add cycle detection #981
Merged
+68
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying electron-website with
|
| Latest commit: |
9a8d810
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4ae1128a.electron-website.pages.dev |
| Branch Preview URL: | https://e40-pull.electron-website.pages.dev |
erickzhao
commented
Jan 16, 2026
| * Detects if adding a dependency from `from` to `to` would create a cycle. | ||
| * Uses DFS to check if `to` transitively depends on `from`. | ||
| */ | ||
| function wouldCreateCycle(from: string, to: string): boolean { |
Member
Author
There was a problem hiding this comment.
Had to add cycle detection to this graph traversal 💀
erickzhao
changed the title
dsanders11
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changes in Electron 40.