Log real names instead of hashes in IdentifierHash class in Launch Manager#58
Open
TimoSteuerwaldETAS wants to merge 3 commits intoeclipse-score:mainfrom
Open
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
IdentifierHashclass is used to identify process group (states) in a memory efficient way. This is why it stores only a hash value of the string which is given at construction time.As it confusing to print hash values in log messages, a static map and a operator<< is introduced in the class which provides a easy way to print understandable strings for an IdentifierHash object, by still leaving the object as memory efficient as before.
Related to #57