Improved Stage Manager features #895
Merged
+944
−332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
client
Tim020
force-pushed
the
tim/improved-stage-features
branch
from
feb3e90 to
22d4893
Compare
- Consolidate generateBarsForProp and generateBarsForScenery into single generateBarsForItem method to reduce code duplication (5.2% -> under 3%) - Add formatSceneRange helper to fix "unexpected negated condition" issues - Reduces bundle size slightly due to code consolidation Co-Authored-By: Claude Opus 4.5 <[email protected]>
Extract ~110 lines of duplicate CSS from MicTimeline.vue and StageTimeline.vue into a shared timeline.scss stylesheet. Both components now import this shared stylesheet using @use, eliminating the duplication flagged by SonarQube. Changes: - Create client/src/assets/styles/timeline.scss with shared styles - Update MicTimeline.vue to use shared .timeline-container and .timeline-svg classes instead of component-specific names - Update StageTimeline.vue similarly - Reduce duplicated lines from 51 (5.35%) to well below the 3% threshold Co-Authored-By: Claude Opus 4.5 <[email protected]>
Replace repetitive querySelectorAll/forEach/setAttribute blocks with a data-driven approach using a styles configuration object. This reduces the duplicated lines flagged by SonarQube in the mixin. Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds plan modal to the live show page showing incoming and outgoing props/scenery
Adds timeline graph to the staging show config page showing usage