fix(Cache): Added condition on /render flow (Live mode only) to avoid cache in Published mode #34507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion (Live mode only) + Clean up cache logic
ihoffmann-dot
requested review from
dario-daza,
fabrizzio-dotCMS and
nollymar
nollymar
reviewed
Feb 4, 2026
dotCMS/src/main/java/com/dotmarketing/factories/PublishFactory.java
Outdated
Show resolved
Hide resolved
dario-daza
reviewed
Feb 5, 2026
dotCMS/src/main/java/com/dotcms/rendering/velocity/servlet/VelocityLiveMode.java
Outdated
Show resolved
Hide resolved
wezell
requested changes
Feb 5, 2026
dotCMS/src/main/java/com/dotcms/rendering/velocity/servlet/VelocityLiveMode.java
Show resolved
Hide resolved
…e in Published mode + Removed previous code
ihoffmann-dot
commented
Feb 5, 2026
...m/dotmarketing/portlets/htmlpageasset/business/render/page/HTMLPageAssetRenderedBuilder.java
Outdated
Show resolved
Hide resolved
ihoffmann-dot
changed the title
Contributor
fabrizzio-dotCMS
left a comment
fabrizzio-dotCMS
left a comment
There was a problem hiding this comment.
It seems too aggressive, suppressing all caching for live requests. Perhaps testing if the user is an admin is in order
…k if User is ADMIN and PageMode is LIVE
wezell
reviewed
Feb 9, 2026
...m/dotmarketing/portlets/htmlpageasset/business/render/page/HTMLPageAssetRenderedBuilder.java
Outdated
Show resolved
Hide resolved
dotCMS/src/main/java/com/dotcms/rendering/velocity/servlet/VelocityLiveMode.java
Show resolved
Hide resolved
dotCMS/src/main/java/com/dotcms/rendering/velocity/util/VelocityUtil.java
Outdated
Show resolved
Hide resolved
wezell
approved these changes
Feb 9, 2026
Contributor
wezell
left a comment
wezell
left a comment
There was a problem hiding this comment.
good, glad we finally got there. Should have a test
ihoffmann-dot
changed the title
nollymar
approved these changes
Feb 10, 2026
fabrizzio-dotCMS
approved these changes
Feb 10, 2026
wezell
requested changes
Feb 10, 2026
dotCMS/src/main/java/com/dotmarketing/business/StaticPageCacheImpl.java
Outdated
Show resolved
Hide resolved
wezell
approved these changes
Feb 10, 2026
Contributor
wezell
left a comment
wezell
left a comment
There was a problem hiding this comment.
Looks good after null checks - sorry that was a pain!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a condition to the
/renderflow (LIVE mode only, BE users only) to avoid caching in Published mode.Changes
VelocityUtil.shouldPageCacheto bypass the cache when thePageModeisLIVEand the logged-in user is a BE userremovemethod inStaticPageCacheImplMotivation
The issue addressed by this PR is caused by the way cache keys are generated for pages displayed in LIVE mode. We decided to completely disable caching when logged in as a BE user and the
PageModeisLIVE.This issue only occurs in the Published view when using Traditional dotCMS. As a result, incorrect information can be displayed, leading to inconsistencies between LIVE mode and the actual page.
Related Issue
Fixes [DEFECT] Browser displays unpublished version of pages, not respecting Live mode #34405