Conversation
|
@Naim2000 : i would recommend undoing the tab/space fixes you did of the existing defines since we are working on a clang-format that would fix it all :) |
|
lgtm. only draft because its untested @Naim2000 ? |
I wanted to add VIDimming next |
|
@Naim2000 : sorry to be a bit of a prick, mind putting the STM eventcode rework into a different PR? this is a bit much to manage in 1 PR and splitting it up might be easier to review |
|
Just started to wonder if STM_ShutdownToIdleEx should be implemented as a persistent change like LEDMode is |
DacoTaco
left a comment
DacoTaco
left a comment
There was a problem hiding this comment.
before testing with priiloader i have this minor remark that has no functional change.
will test it later
| u16 patterns[STM_MAX_LED_PATTERNS]; | ||
| }; | ||
|
|
||
| // capitalization of LED is debatable. libogc currently has STM_SetLedMode, meanwhile this function is internally called ISTM_StartLEDFlashLoop |
There was a problem hiding this comment.
not sure the comments here and above STM_VIDimming are needed.
this one can be removed i think, but STM_VIDimming isn't saying anything to me.
i dont know what __stm_vdinuse is, or what that comment about 0ms is about, so maybe also remove it?
the function just fades the screen to black right?
2 participants
STM_StartLEDFlashLoopappears. cannot nearly test cause my Wii has no faceplate (☠️ ☠️ ☠️)PR will get a better name soon enough