chore(deps): update definitelytyped #288
Conversation
📝 WalkthroughWalkthroughType-definition package versions were bumped in package.json for Sequence Diagram(s)🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In @package.json:
- Line 2751: Remove the deprecated devDependency entry for
"@types/react-json-tree" from package.json (the line with
"@types/react-json-tree": "^0.13.0") because react-json-tree now ships its own
types; update package.json accordingly and then regenerate your lockfile by
running your package manager install (npm install / yarn install / pnpm install)
so the lockfile reflects the removal.
- Line 2758: The dependency list contains an unused typing package: keep the
updated "@types/stack-trace" (used by src/platform/errors/index.ts) but remove
the stray "@types/temp" entry (the codebase imports/uses "tmp", not "temp");
delete the "@types/temp" line from package.json, then run your package manager
(npm/yarn/pnpm) to update node_modules and the lockfile so the removed typing is
fully cleaned from the dependency graph.
- Line 2747: The package list contains an orphaned dev-type and a type version
mismatch: remove the unused type package @types/react-json-tree (or add the
corresponding runtime react-json-tree dependency if the library is actually
used) and reconcile @types/pdfkit (currently ^0.17.0) with the runtime
[email protected] by either downgrading the type package to the matching major/minor
version or upgrading pdfkit to a version compatible with the @types/pdfkit
release; after adjusting package.json update lockfile (npm/yarn/pnpm) and run
TypeScript compilation and relevant tests to ensure the pdfkit type definitions
do not reference APIs newer than the installed pdfkit runtime.
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Lint & Format
- GitHub Check: copilot-setup-steps
| "@types/sinon": "^10.0.15", | ||
| "@types/sinonjs__fake-timers": "^6.0.1", | ||
| "@types/stack-trace": "0.0.29", | ||
| "@types/stack-trace": "0.0.33", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify usage of 'temp' package (distinct from 'tmp')
rg -n --type ts --type tsx -C3 "from ['\"]temp['\"]|require\(['\"]temp['\"]"Repository: deepnote/vscode-deepnote
Length of output: 95
🏁 Script executed:
#!/bin/bash
# Verify usage of 'temp' package - search in JS and TS files
rg -n "from ['\"]temp['\"]|require\(['\"]temp['\"]" --type ts --type jsRepository: deepnote/vscode-deepnote
Length of output: 50
🏁 Script executed:
#!/bin/bash
# Check if stack-trace is used in the codebase
rg -n "from ['\"]stack-trace['\"]|require\(['\"]stack-trace['\"]" --type ts --type js
echo "---"
# Also check package.json context around these lines
sed -n '2750,2770p' package.jsonRepository: deepnote/vscode-deepnote
Length of output: 1027
🏁 Script executed:
#!/bin/bash
# Check if 'temp' runtime package exists in dependencies
rg -n "^\s*\"temp\":" package.json
echo "---"
# Check devDependencies section for temp
rg -n "\"temp\"" package.json | head -20Repository: deepnote/vscode-deepnote
Length of output: 71
🏁 Script executed:
#!/bin/bash
# Check if 'tmp' runtime package exists in dependencies (different from 'temp')
rg -n "\"tmp\":" package.json
echo "---"
# Get dependencies and devDependencies sections
rg -n "dependencies|devDependencies" package.json | head -5Repository: deepnote/vscode-deepnote
Length of output: 335
@types/stack-trace update is safe; @types/temp appears unused.
@types/stack-trace (0.0.29 → 0.0.33) is valid—the package is imported in src/platform/errors/index.ts. However, @types/temp at line 2762 should likely be removed: the temp package is not imported anywhere in the codebase, whereas tmp (at line 2702) is the actual runtime dependency used. Consider removing the unused @types/temp.
🤖 Prompt for AI Agents
In @package.json at line 2758, The dependency list contains an unused typing
package: keep the updated "@types/stack-trace" (used by
src/platform/errors/index.ts) but remove the stray "@types/temp" entry (the
codebase imports/uses "tmp", not "temp"); delete the "@types/temp" line from
package.json, then run your package manager (npm/yarn/pnpm) to update
node_modules and the lockfile so the removed typing is fully cleaned from the
dependency graph.
renovate
bot
force-pushed
the
renovate/definitelytyped
branch
from
edeb4e7 to
23d03e1
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
🔇 Additional comments (1)
package.json (1)
2727-2727: Routine type definition bumps.These updates (
@types/react-json-tree,@types/stack-trace,@types/temp) are minor/patch-level. Should be safe.Also applies to: 2734-2734, 2738-2738
renovate
bot
force-pushed
the
renovate/definitelytyped
branch
4 times, most recently
from
9b54bb5 to
76a860e
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @package.json:
- Line 2727: Remove the deprecated unused type package @types/react-json-tree
from package.json (and from any devDependencies section if present) since
react-json-tree ships its own types; then run npm install (or yarn install) to
update package-lock.json, verify package-lock no longer contains the stub, and
run the test/build to ensure no type errors remain.
- Line 2723: The dev dependency mismatch: @types/pdfkit@^0.17.0 targets pdfkit
~0.17.x while your project depends on pdfkit 0.13.0, causing TypeScript type
errors; fix by either upgrading the runtime package pdfkit to a compatible
0.17.x release or by pinning @types/pdfkit to a version that matches 0.13.x
(choose one approach and update package.json entries for "pdfkit" or
"@types/pdfkit" accordingly), then reinstall node_modules and run the TypeScript
build/tests to verify the error is resolved.
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: TypeCheck
🔇 Additional comments (1)
package.json (1)
2734-2734: Minor type updates look reasonable.
@types/stack-trace(0.0.29 → 0.0.33) and@types/temp(^0.8.32 → ^0.9.0) are smaller bumps. Should be safe but run TypeScript compilation to confirm.Also applies to: 2738-2738
renovate
bot
force-pushed
the
renovate/definitelytyped
branch
from
76a860e to
1f36133
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @package.json:
- Around line 2723-2738: The listed type packages are mismatched or unnecessary:
ensure @types/pdfkit matches the installed runtime pdfkit version (either
upgrade runtime pdfkit to >=^0.13.0 or pin @types/pdfkit to the compatible
version), align @types/stack-trace with the installed stack-trace runtime
(upgrade stack-trace to 0.0.33 or downgrade @types/stack-trace to 0.0.10),
remove @types/temp and instead add @types/tmp to match the runtime usage of tmp,
and remove @types/react-json-tree from devDependencies since the runtime package
is not used; update package.json devDependencies accordingly and run install +
type checks to validate.
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
| "@types/pdfkit": "^0.17.0", | ||
| "@types/promisify-node": "^0.4.0", | ||
| "@types/react": "^16.4.14", | ||
| "@types/react-dom": "^16.0.8", | ||
| "@types/react-json-tree": "^0.6.8", | ||
| "@types/react-json-tree": "^0.13.0", | ||
| "@types/react-redux": "^7.1.5", | ||
| "@types/react-virtualized": "^9.21.2", | ||
| "@types/redux-logger": "^3.0.7", | ||
| "@types/semver": "^5.5.0", | ||
| "@types/sinon": "^10.0.15", | ||
| "@types/sinonjs__fake-timers": "^6.0.1", | ||
| "@types/stack-trace": "0.0.29", | ||
| "@types/stack-trace": "0.0.33", | ||
| "@types/strip-comments": "^2.0.1", | ||
| "@types/svg-to-pdfkit": "^0.1.0", | ||
| "@types/tcp-port-used": "^1.0.0", | ||
| "@types/temp": "^0.8.32", | ||
| "@types/temp": "^0.9.0", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check runtime package versions and type definition versions
echo "=== Checking package.json for runtime packages ==="
rg -n '"pdfkit"|"stack-trace"|"temp"|"react-json-tree"' package.json
echo ""
echo "=== Checking package.json for type definitions (lines around 2723-2738) ==="
sed -n '2700,2750p' package.json
echo ""
echo "=== Check for temp/tmp usage ==="
rg -l 'require.*temp|from.*["\']temp["\']|require.*tmp|from.*["\']tmp["\']' --type ts --type js 2>/dev/null | head -20 || echo "Checking alternative patterns..."
echo ""
echo "=== Check for react-json-tree usage ==="
rg 'react-json-tree' --type ts --type js 2>/dev/null | head -10 || echo "No react-json-tree usage found"Repository: deepnote/vscode-deepnote
Length of output: 2405
🏁 Script executed:
#!/bin/bash
# Check for temp, tmp, and react-json-tree in dependencies
echo "=== Searching for temp/tmp/react-json-tree in dependencies section ==="
grep -n '"temp"\|"tmp"\|"react-json-tree"' package.json | head -20
echo ""
echo "=== Check codebase for react-json-tree imports ==="
find . -type f \( -name "*.ts" -o -name "*.tsx" -o -name "*.js" \) -exec grep -l "react-json-tree" {} \; 2>/dev/null | head -10
echo ""
echo "=== Check codebase for temp/tmp imports ==="
find . -type f \( -name "*.ts" -o -name "*.tsx" -o -name "*.js" \) -exec grep -l "require.*tmp\|from.*['\"]tmp['\"]" {} \; 2>/dev/null | head -10Repository: deepnote/vscode-deepnote
Length of output: 477
Remove mismatched type definitions and update version gaps.
@types/pdfkit^0.17.0 requires runtimepdfkit≥ ^0.13.0, but only ^0.13.0 is installed—verify compatibility or downgrade types@types/stack-trace0.0.33 targets stack-trace 0.0.33, but only 0.0.10 is installed—major gap, update or downgrade types@types/temp^0.9.0 has no corresponding runtime package (runtime usestmp, nottemp)—remove or replace with@types/tmp@types/react-json-tree^0.13.0 unused in codebase and missing runtime dependency—remove
🤖 Prompt for AI Agents
In @package.json around lines 2723 - 2738, The listed type packages are
mismatched or unnecessary: ensure @types/pdfkit matches the installed runtime
pdfkit version (either upgrade runtime pdfkit to >=^0.13.0 or pin @types/pdfkit
to the compatible version), align @types/stack-trace with the installed
stack-trace runtime (upgrade stack-trace to 0.0.33 or downgrade
@types/stack-trace to 0.0.10), remove @types/temp and instead add @types/tmp to
match the runtime usage of tmp, and remove @types/react-json-tree from
devDependencies since the runtime package is not used; update package.json
devDependencies accordingly and run install + type checks to validate.
1f36133 to
9266105
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @package.json:
- Line 2727: Remove the deprecated dependency entry "@types/react-json-tree"
from package.json and update the lockfile: delete the "@types/react-json-tree"
line from the dependencies/devDependencies block, run npm install (or yarn
install) to regenerate package-lock.json (or yarn.lock), and commit the updated
lockfile; ensure there are no imports referencing "@types/react-json-tree" (the
review indicates none) before pushing.
- Line 2723: The package.json declares a version mismatch between the types and
runtime for PDFKit: "@types/pdfkit" is ^0.17.0 while "pdfkit" is ^0.13.0; update
either the runtime "pdfkit" to a version compatible with the @types (e.g., bump
"pdfkit" to a version >=0.17.0 that matches the type definitions) or downgrade
"@types/pdfkit" to a version that matches "pdfkit" ^0.13.0 so IDE/type hints
reflect the actual runtime API; ensure the package.json entries for "pdfkit" and
"@types/pdfkit" are aligned and run a quick type-check after updating.
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Lint & Format
🔇 Additional comments (1)
package.json (1)
2734-2734: Minor type definition updates look fine.
@types/stack-trace(0.0.29 → 0.0.33) and@types/temp(^0.8.32 → ^0.9.0) are low-risk patch/minor bumps.Also applies to: 2738-2738
| "@types/node": "^22.15.1", | ||
| "@types/node-fetch": "^2.6.12", | ||
| "@types/pdfkit": "^0.11.0", | ||
| "@types/pdfkit": "^0.17.0", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
echo "=== Checking pdfkit and @types/pdfkit versions ==="
rg -n '"pdfkit"|"@types/pdfkit"' package.json
echo -e "\n=== Checking pdfkit imports in codebase ==="
rg -n 'import.*pdfkit|require.*pdfkit' --type ts --type jsRepository: deepnote/vscode-deepnote
Length of output: 519
🌐 Web query:
@types/pdfkit 0.17.0 compatibility pdfkit 0.13.0
💡 Result:
Short answer: Mostly — but not guaranteed. @types/pdfkit v0.17.x provides TypeScript definitions that target the newer pdfkit APIs added after v0.13 (0.14–0.17 added features like tables, PDF/A, accessibility, new text/font options). Using @types/[email protected] with [email protected] will work for the older, unchanged APIs, but you may see type declarations for methods/options that don't exist in pdfkit 0.13.0 (false positives) or missing types for older undocumented behavior. If you need strict correctness, use matching/closer versions of the types or pin to a types version that documents pdfkit 0.13.x.
Sources:
- @types/pdfkit (npm/DefinitelyTyped package info). [1]
- pdfkit releases / changelog showing features added after 0.13.0 (0.14–0.17). [2][3]
References:
[1] npm: @types/pdfkit package info.
[2] foliojs/pdfkit releases (v0.13.0, v0.14.0, v0.17.0).
[3] PDFKit changelog / release notes.
Fix type definition version mismatch.
@types/pdfkit is ^0.17.0 but pdfkit is ^0.13.0. The types package targets APIs introduced in v0.14–0.17, which don't exist in v0.13.0. This will cause false-positive type hints in IDEs. Either align the types version to match the runtime library or upgrade pdfkit to support the newer type definitions.
🤖 Prompt for AI Agents
In @package.json at line 2723, The package.json declares a version mismatch
between the types and runtime for PDFKit: "@types/pdfkit" is ^0.17.0 while
"pdfkit" is ^0.13.0; update either the runtime "pdfkit" to a version compatible
with the @types (e.g., bump "pdfkit" to a version >=0.17.0 that matches the type
definitions) or downgrade "@types/pdfkit" to a version that matches "pdfkit"
^0.13.0 so IDE/type hints reflect the actual runtime API; ensure the
package.json entries for "pdfkit" and "@types/pdfkit" are aligned and run a
quick type-check after updating.
| "@types/react": "^16.4.14", | ||
| "@types/react-dom": "^16.0.8", | ||
| "@types/react-json-tree": "^0.6.8", | ||
| "@types/react-json-tree": "^0.13.0", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check react-json-tree usage
rg -n --type ts --type tsx 'react-json-tree' -C2Repository: deepnote/vscode-deepnote
Length of output: 95
🏁 Script executed:
#!/bin/bash
# Check react-json-tree usage - search all files
rg -n 'react-json-tree' -C2Repository: deepnote/vscode-deepnote
Length of output: 4078
🏁 Script executed:
#!/bin/bash
# Search for imports of react-json-tree in source files (not node_modules or package files)
rg -n 'import.*react-json-tree|from.*react-json-tree|require.*react-json-tree' --glob '!node_modules' --glob '!package*.json'Repository: deepnote/vscode-deepnote
Length of output: 50
Remove @types/react-json-tree — it's deprecated and unused.
The package-lock.json shows this is marked as deprecated: "This is a stub types definition. react-json-tree provides its own type definitions, so you do not need this installed." No source code imports were found. Remove the dependency entirely rather than bumping versions.
🤖 Prompt for AI Agents
In @package.json at line 2727, Remove the deprecated dependency entry
"@types/react-json-tree" from package.json and update the lockfile: delete the
"@types/react-json-tree" line from the dependencies/devDependencies block, run
npm install (or yarn install) to regenerate package-lock.json (or yarn.lock),
and commit the updated lockfile; ensure there are no imports referencing
"@types/react-json-tree" (the review indicates none) before pushing.
This PR contains the following updates:
4.3.6→4.3.202.0.1→2.0.37.1.6→7.1.82.8.12→2.8.194.1.7→4.1.120.7.0→0.7.24.0.0→4.0.31.0.2→1.0.45.0.37→5.0.385.0.3→5.0.75.13.4→5.13.104.14.181→4.17.2318.19.31→18.19.13022.15.31→22.19.52.6.12→2.6.13^0.11.0→^0.17.00.4.0→0.4.316.9.14→16.9.25^0.6.8→^0.13.07.1.23→7.1.349.21.20→9.22.33.0.9→3.0.1310.0.15→10.0.200.0.29→0.0.332.0.1→2.0.40.1.0→0.1.31.0.1→1.0.4^0.8.32→^0.9.00.2.3→0.2.61.4.8→1.4.111.88.0→1.108.11.60.0→1.72.4Configuration
📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.