direct: support quality monitors #4278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
Contributor
andrewnester
left a comment
andrewnester
left a comment
There was a problem hiding this comment.
Could you please include known differences between TF and direct implementation in the PR description?
| @@ -0,0 +1,14 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
It looks like the update now causes a recreation instead of the actual update, which leads to a quality monitor URL / id change. This URL / ID might be referenced from other places (outside of bundle scope, like let's say some dashboard)
Is this recreation intentional?
Contributor
Author
There was a problem hiding this comment.
yes, because assets_dir is not available on update request for quality monitors, so it simply cannot be updated.
https://docs.databricks.com/api/workspace/qualitymonitors/update
Collaborator
|
Commit: 906aed8
26 interesting tests: 19 RECOVERED, 6 KNOWN, 1 SKIP
Top 29 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Jan 14, 2026
deco-sdk-tagging bot
added a commit
that referenced
this pull request
Jan 14, 2026
## Release v0.283.0 ### Notable Changes * Bundle commands now cache the user's account details to improve command latency. To disable this, set the environment variable DATABRICKS_CACHE_ENABLED to false. ### CLI * Add commands to pipelines command group ([#4275](#4275)) ### Bundles * Add support for configuring app.yaml options for apps via bundle config ([#4271](#4271)) * Enable caching user identity by default ([#4202](#4202)) * Do not show single node warning when is_single_node option is explicitly set ([#4272](#4272)) * Fix false positive folder permission warnings and make them more actionable ([#4216](#4216)) * Pass additional Azure DevOps system variables ([#4236](#4236)) * Replace Black formatter with Ruff in Python bundle templates for faster, all-in-one linting and formatting ([#4196](#4196)) * engine/direct: support quality monitors ([#4278](#4278)) * Improve folder permissions warning ([#4216](#4216)) ### Dependency updates * Upgrade TF provider to 1.102.0 ([#4235](#4235)) * Upgrade Go SDK to 0.96.0 ([#4206](#4206))
Collaborator
|
Commit: 1241eb8
32 interesting tests: 17 RECOVERED, 8 flaky, 6 KNOWN, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Support quality monitors in direct engine. Compared to terraform, this supports changing assets_dir and table_name (by recreating the monitor).
Why
Closes #4158
Tests
New local + cloud tests.