feat: Add new fields to conversation api#1640
Open
javier-aliaga wants to merge 2 commits intodapr:masterfrom
Open
feat: Add new fields to conversation api#1640javier-aliaga wants to merge 2 commits intodapr:masterfrom
javier-aliaga wants to merge 2 commits intodapr:masterfrom
Conversation
javier-aliaga
force-pushed
the
update-conversation-api
branch
2 times, most recently
from
3b8b13b to
cc22ce8
Compare
Signed-off-by: Javier Aliaga <javier@diagrid.io>
javier-aliaga
force-pushed
the
update-conversation-api
branch
from
cc22ce8 to
c75ca06
Compare
Collaborator
|
/LGTM .. all green so I think we can merge this |
salaboy
previously approved these changes
Feb 5, 2026
siri-varma
reviewed
Feb 5, 2026
Contributor
siri-varma
left a comment
siri-varma
left a comment
There was a problem hiding this comment.
@javier-aliaga Quick question, should we also update/create the conversation api examples with these new fields ?
Contributor
Author
|
@siri-varma the problem is these new fields are only supported by some components but not the echo service. I modified the examples to print the usage in case the model is present. Let me work on the ResponseFormat, I would like to do a real test |
Signed-off-by: Javier Aliaga <javier@diagrid.io>
javier-aliaga
force-pushed
the
update-conversation-api
branch
from
103cfb2 to
02fa598
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1640 +/- ##
============================================
+ Coverage 78.99% 79.18% +0.19%
- Complexity 2096 2122 +26
============================================
Files 228 231 +3
Lines 6322 6386 +64
Branches 693 695 +2
============================================
+ Hits 4994 5057 +63
- Misses 976 978 +2
+ Partials 352 351 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add new fields for conversation api
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1639
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: