Update BIP-32 section to make clear xpub exposure risks to attacker with CRQC#28
Open
xoloki wants to merge 2 commits intocryptoquick:p2qrhfrom
Open
Update BIP-32 section to make clear xpub exposure risks to attacker with CRQC#28xoloki wants to merge 2 commits intocryptoquick:p2qrhfrom
xoloki wants to merge 2 commits intocryptoquick:p2qrhfrom
Conversation
…pose all child keys given an xpub
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing
BIP-32section does not make it clear that an attacker with a CRQC can recover the xpriv from an xpub, and thereby expose all child keys. This PR updates that paragraph to make this conclusion explicit.I also made a minor wording change in the "Satoshi's Shield" section.