feat: Add support for loading images with blob urls#41
Open
meetmangukiya wants to merge 1 commit intocornerstonejs:masterfrom
Open
feat: Add support for loading images with blob urls#41meetmangukiya wants to merge 1 commit intocornerstonejs:masterfrom
meetmangukiya wants to merge 1 commit intocornerstonejs:masterfrom
Conversation
Register `blob` as scheme instead of `blob:http` or `blob:https` because cornerstone-core splits on `:` and uses the first part as the scheme. So, if provided a url `blob:https://github.com/test-id` it will consider `blob` as the scheme instead of `blob:https`. Closes cornerstonejs#13
Author
|
Not sure how the coverage got decreased since we are just importing the whole module for giving an illusion of coverage(I think)? Also, can we have a release after this is merged @chafey(mentioning for notification since no new commit in last 6 months and you are mentioned as package author) ? |
Author
|
In the meanwhile if anyone wishes to use this I've published it to github package - https://github.com/flamy-dev/cornerstoneWebImageLoader/packages/297934 |
|
This change would be extremely useful. Thanks @meetmangukiya What do expect me to do in order to help with merging this one? |
Author
|
@Inzeppelin don't think this is going to be merged, better fork |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register
blobas scheme instead ofblob:httporblob:httpsbecausecornerstone-core splits on
:and uses the first part as the scheme. So,if provided a url
blob:https://github.com/test-idit will considerblobas the scheme instead of
blob:https.Closes #13