fix(js-catcher): allow optional context and set statusCode on fetch fail #152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Two small fixes in the JavaScript catcher:
Validation — optional context

validateContext()was treating missing/undefined context as invalid and logging "Context must be an object". Context is optional inHawkInitialSettingsand insetContext(context?: EventContext), so undefined should pass validation.Updated the check to only fail when context is present but not an object (
context && !Sanitizer.isObject(context)), so undefined is accepted.Breadcrumbs — fetch failure
When a fetch request fails (e.g. network error), the breadcrumb in the catch block now explicitly sets
statusCode: 0indata, so the UI can consistently treat failed requests (e.g. for coloring).