Schedule times are not a heading #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From discussion on #50 — the talk times on the schedule are
h2headings. I think the logical hierarchy of the schedule page is h1 Page Title > h2 Talk Group > h3 Individual talk titles. I don't think the times rise to the level of a heading, but it is debatable.Before this PR WAVE should show twice as many Heading level 2 elements. For instance, the schedule day 1 has 24 level 2 headings before and only 12 afterwards. This PR shouldn't conflict with #50 and can be merged independently.