Expose and validate connection.tags property #327
Merged
+230
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a read-only connection.tags property and tag handling across the partyserver Durable Object. Introduces prepareTags() to dedupe and validate tags (always prepends the connection id, max 10 tags, non-empty strings, <=256 chars). Persist tags in the connection attachment for hibernating connections (default to [] for older attachments) and expose tags on in-memory connections via a property. Update createLazyConnection, connection attachment parsing, and both connection managers to use the helper. Includes type updates, new tests covering hibernating and in-memory tag behavior, and wrangler test config additions.
🦋 Changeset detectedLatest commit: 94d08c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #254
Add a read-only connection.tags property and tag handling across the partyserver Durable Object. Introduces prepareTags() to dedupe and validate tags (always prepends the connection id, max 10 tags, non-empty strings, <=256 chars). Persist tags in the connection attachment for hibernating connections (default to [] for older attachments) and expose tags on in-memory connections via a property. Update createLazyConnection, connection attachment parsing, and both connection managers to use the helper. Includes type updates, new tests covering hibernating and in-memory tag behavior, and wrangler test config additions.