Fix: reconnect() not working after maxRetries exhausted
#322
+43
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes cloudflare/partykit#252 — calling
ws.reconnect()aftermaxRetrieshas been exhausted now correctly resets and initiates a new connection.Problem
In
_connect(), whenmaxRetriesis reached, the method acquires_connectLock = truebut returns early without releasing it. This leaves the lock permanently held, so any subsequent call toreconnect()(which resets_retryCountand calls_connect()) silently bails out at the lock check — making it impossible to manually reconnect after automatic retries are exhausted.This is a common scenario when a user wants to force a reconnection on window focus after the tab has been inactive and retries have been spent.
Fix
Release
_connectLockbefore the early return in themaxRetriesguard inside_connect():if (this._retryCount >= maxRetries) { this._debug("max retries reached", this._retryCount, ">=", maxRetries); + this._connectLock = false; return; }Test plan