fix build issue when include clBLAS as a cmake subproject#332
Open
yang-le wants to merge 3 commits intoclMathLibraries:developfrom
Open
fix build issue when include clBLAS as a cmake subproject#332yang-le wants to merge 3 commits intoclMathLibraries:developfrom
yang-le wants to merge 3 commits intoclMathLibraries:developfrom
Conversation
Contributor
|
change CMAKE_SOURCE_DIR to CMAKE_CURRENT_SOURCE_DIR is good and recommended. Why change build *.so to OFF? Please modify this OFF. |
revert prev change
Author
|
OK, previous change reverted from CMakeLists.txt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When include clBLAS as a cmake subproject using add_subdectory(), it seems that some paths are wrong.
To fix it, I just replace ${CMAKE_SOURCE_DIR}/library with ${CMAKE_CURRENT_SOURCE_DIR} and it works.