Added ButtonIconFontSize and ButtonIconFontSizeAuto to ActionButton, Fixed WizardPageXaml#44
Open
renzska wants to merge 2 commits intochrfalch:developfrom
Open
Added ButtonIconFontSize and ButtonIconFontSizeAuto to ActionButton, Fixed WizardPageXaml#44renzska wants to merge 2 commits intochrfalch:developfrom
renzska wants to merge 2 commits intochrfalch:developfrom
Conversation
WizardPageXaml didn’t have any events and had same text for the two pages that were in it. I modified it to match WizardPage.cs Update paging numbers on WizardPage.cs (started at 2, should start at 1).
renzska
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ButtonIconFontSize and ButtonIconFontSizeAuto to ActionButton to allow either autofont sizing or custom font sizing. I needed to be able to change the Font Awesome Icon size when buttons were larger than 56px.
The key parts (removed formatting changes from last PR):
ButtonIconFontSize
ButtonIconFontSizeAuto
override LayoutChildren
Also Fixed WizardPageXaml
Let me know if you need further explanation.