feat: general tab & header #3975
Merged
+181
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Sebastien-Ahkrin
commented
Feb 11, 2026
Sebastien-Ahkrin
commented
- feat: add validation to the general tab
- fix: check to see if experimental features enabled
- feat: add cancel button
- fix: eslint
- feat: wip
- feat: add correct submit & apply
- refactor: destructure validation
- fix: re-add copy / paste
- fix: eslint
Deploying nmrium with
|
| Latest commit: |
bb30eea
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://89aaaab0.nmrium.pages.dev |
| Branch Preview URL: | https://feat-general-tab.nmrium.pages.dev |
tpoisseau
approved these changes
Feb 11, 2026
Contributor
tpoisseau
left a comment
tpoisseau
left a comment
There was a problem hiding this comment.
LGTM.
I did not checked or tested it thoroughly to not block you. We will verify the form is working properly once it is fully implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.