refactor: change header to use zod and new form #3957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying nmrium with
|
| Latest commit: |
97692b5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://78947881.nmrium.pages.dev |
| Branch Preview URL: | https://refactor-header-dialog.nmrium.pages.dev |
Collaborator
Author
|
Care, the func' isn't perfectly working ... Its only a good base to check if values are correctly binded between the two forms |
tpoisseau
reviewed
Feb 2, 2026
src/component/modal/setting/tanstack_general_settings/validation/utils.ts
Outdated
Show resolved
Hide resolved
src/component/modal/setting/tanstack_general_settings/general_settings.tsx
Outdated
Show resolved
Hide resolved
src/component/modal/setting/tanstack_general_settings/general_settings.tsx
Outdated
Show resolved
Hide resolved
src/component/modal/setting/tanstack_general_settings/general_settings.tsx
Outdated
Show resolved
Hide resolved
src/component/modal/setting/tanstack_general_settings/general_settings.tsx
Outdated
Show resolved
Hide resolved
src/component/modal/setting/tanstack_general_settings/general_settings_dialog_header.tsx
Show resolved
Hide resolved
src/component/modal/setting/tanstack_general_settings/general_settings_dialog_header.tsx
Outdated
Show resolved
Hide resolved
tpoisseau
approved these changes
Feb 6, 2026
src/component/modal/setting/tanstack_general_settings/general_settings.tsx
Show resolved
Hide resolved
src/component/modal/setting/tanstack_general_settings/general_settings.tsx
Show resolved
Hide resolved
src/component/modal/setting/tanstack_general_settings/general_settings.tsx
Show resolved
Hide resolved
src/component/modal/setting/tanstack_general_settings/general_settings_dialog_header.tsx
Show resolved
Hide resolved
This was referenced Feb 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.