DPE-9158 Speedup action list-backups (from minutes to seconds) #1375
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
At the moment charm action
list-backupsexecutes minutes on S3 buckets with hundreds backups,while some common backups have thousand of backups causing action timeout.
The often config is hold backups for 30 days with nightly full backup and incremental backup each 15 minutes.
Solution
List S3 content recursively for
archivepart only. It will be enough to generate Timelines list.This will skip the biggest neighbor folder
backups, which used to eat most of the time in _list_timelines().Checklist