add overlap functionality to Timex.Interval#492
Closed
glassbead0 wants to merge 1 commit intobitwalker:masterfrom
Closed
add overlap functionality to Timex.Interval#492glassbead0 wants to merge 1 commit intobitwalker:masterfrom
glassbead0 wants to merge 1 commit intobitwalker:masterfrom
Conversation
jasonnoble
reviewed
Dec 7, 2018
glassbead0
force-pushed
the
add_overlap_duration_to_interval
branch
from
bc21381 to
66fe784
Compare
* determine the overlap duration between two intervals. * Can specify a valid unit for Durations. * Will return a Duration struct or integer depending on the unit provided (default to :seconds) * Will return 0 (or eqivalent Duration struct) for intervals that do not overlap.
glassbead0
force-pushed
the
add_overlap_duration_to_interval
branch
from
66fe784 to
09b30fc
Compare
Contributor
Author
|
changed the suggested implementation to return the overlap interval rather than the duration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
two intervals.
depending on the unit provided (default
to :seconds)
struct) for intervals that do not overlap.
Checklist