[BC/CWC] Wallet private key updates [1] #4068
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sses, & expose method with DeriverProxy
…sses and add passthrough on DeriverProxy
…t to expected form
kajoseph
added
CWC
MichaelAJay
changed the title
kajoseph
reviewed
Jan 22, 2026
Collaborator
kajoseph
left a comment
kajoseph
left a comment
There was a problem hiding this comment.
I think a better approach may be to auto migrate wallets with version < 2 to v2. That way we can avoid carve-outs while actively push better security.
loadWallet() {
const wallet = read wallet file;
if (wallet.version < 2) {
convert to v2 wallet;
backup wallet file to .bak;
overwrite wallet file with v2;
}
}
| if (Buffer.isBuffer(privKey)) return privKey; | ||
| if (typeof privKey !== 'string') throw new Error(`Expected string, got ${typeof privKey}`); | ||
| // Expects to match return from derivePrivateKey's privKey. | ||
| return Buffer.from(privKey, 'hex'); |
Collaborator
There was a problem hiding this comment.
should strip leading 0x if present
| * @returns {Buffer} | ||
| * @throws {Error} If privKey is not a Buffer (planned forwards compatibility) or string. Propagates all other errors | ||
| * | ||
| * TODO |
| * @returns {Buffer} raw secpk1 private key buffer (32 bytes, big-endian) | ||
| * @throws {Error} If privKey is not a Buffer (planned forwards compatibility) or string. Propagates all other errors | ||
| */ | ||
| privateKeyToBuffer(privKey: any): Buffer { |
Collaborator
There was a problem hiding this comment.
Why are we not more strict with the input type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bitcore-client
Encryption
Storage
addKeysSafe- incoming keys' private key is encrypted, so not immediately available to be used to retrieve pubkey, which should be available anyway. Throws if missing a pubkeyWallet
createencrypts HDPrivateKey xprivkey and privateKey so they can be decrypted as buffers instead of serializing the whole masterKey and THEN encryptingimportKeysdoes the same for signing keyssignTxdecrypts to buffers then uses deriver for chain-aware decoding. In the next phase, this decoding should be made unnecessary by passing the buffer all the way through to use, if possibleTests
crypto-wallet-core
Derivation
privateKeyToBufferandprivateKeyBufferToNativePrivateKeyto IDeriver & implement for each Deriver - no need to override for any of the extending classes (UTXOs to AbstractBitcoreLibDeriver & EVM to EthDeriver)