This repository was archived by the owner on Jun 5, 2023. It is now read-only.
UTC datetime#70
Open
duxiaoyao wants to merge 2 commits intobinarymatt:masterfrom
duxiaoyao:utc_datetime
Open
Conversation
…amp for scheduling; work with naive UTC datetimes internally; convert datetimes to naive UTC right after received from external(ResQ.enqueue_at).
Owner
|
sorry i haven't done anything with this yet. I've been moving houses recently and haven't had time to review. Hopefully I will get time this week. |
|
It would be awesome if this was merged in - UTC everything would be sweet. |
|
Thanks! |
Owner
|
i'm hoping to sit down and figure out how I can apply this change to the current codebase cleanly. If I have to, i'll pull in bits and pieces. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs with local datetimes:
There were discussions on the thread "move pyres times from local timezone to UTC" in the mailing list.
Changes did: