⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@meelon-dev
Copy link

The README.md file for the template-funding uses the following line:

cd <network>/<date>safe-swap-owner

This does not follow the logic, as it selects the execution bundle for the swap owner, not for funding:

  • mainnet/2025-06-25-safe-swap-owner/README.md correctly refers to the safe-swap-owner.
  • mainnet/2025-08-13-safe-swap-owner/README.md also correctly refers to the safe-swap-owner.
  • mainnet/2025-10-06-funding/README.md follows the logic and has cd mainnet/2025-10-06-funding.

A comparison shows that the template-funding simply copies the safe-swap-owner path, which is not adapted for funding.
Updated template-funding so that the path follows the funding logic.

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 2
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 2
2
1 if commit is unverified 0
Sum 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants