⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@kmcginnes
Copy link
Collaborator

Description

Fix an error only shown in the console reporting a button within a button.

The Collapsible trigger is a button, and the content of the trigger contains an add/remove button. To fix it I nest the content in a div and use asChild.

Validation

  • Ensured search results still expand
  • Ensured vertex can still be added

Related Issues

  • None

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes marked this pull request as ready for review January 10, 2026 23:03
@codecov
Copy link

codecov bot commented Jan 10, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.11%. Comparing base (c5affc5) to head (9f4b3a2).
⚠️ Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
...ges/graph-explorer/src/components/SearchResult.tsx 0.00% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1447       +/-   ##
===========================================
+ Coverage   47.81%   62.11%   +14.30%     
===========================================
  Files         382      306       -76     
  Lines        8525     6338     -2187     
  Branches     3159     2220      -939     
===========================================
- Hits         4076     3937      -139     
+ Misses       3070     1683     -1387     
+ Partials     1379      718      -661     
Flag Coverage Δ
unittests 62.11% <0.00%> (+14.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant