Fix issue where navigationItem would not be displayed under iOS 7#210
Open
timbodeit wants to merge 1 commit intoaryaxt:masterfrom
Open
Fix issue where navigationItem would not be displayed under iOS 7#210timbodeit wants to merge 1 commit intoaryaxt:masterfrom
timbodeit wants to merge 1 commit intoaryaxt:masterfrom
Conversation
For reasons, that I currenlty do not understand, the self.enableShadow and self.enableSwipeGesture calls in SlideNavigationController#setup cause problems under iOS 7 in my setup. I am instanciating a SlideNavigationController through a storyboard. While iOS 8 and 9 work fine, under iOS 7 I was seeing an empty navigation bar. It did have a navigationItem, though that didn't match the topViewController and didn't have any title or buttonItems. I assume this issue arises from enableShadow and enableSwipeGesture both accessing the view property, while being called before viewDidLoad. Deferring both of these calls and making them during them during viewDidLoad instead of during init, resolves the issue that I have been seeing under iOS 7.
Owner
|
Thanks for the PR: Couple of questions 1- Are you able to reproduce this in the demo app? self.enableShadow and self.enableSwipeGesture call setup because as you try to access them the singleton object gets instantiated. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For reasons, that I currenlty do not understand, the self.enableShadow and
self.enableSwipeGesture calls in SlideNavigationController#setup cause problems
under iOS 7 in my setup.
I am instanciating a SlideNavigationController through a storyboard. While iOS
8 and 9 work fine, under iOS 7 I was seeing an empty navigation bar. It did
have a navigationItem, though that didn't match the topViewController and
didn't have any title or buttonItems.
I assume this issue arises from enableShadow and enableSwipeGesture both
accessing the view property, while being called before viewDidLoad.
Deferring both of these calls and making them during them during viewDidLoad
instead of during init, resolves the issue that I have been seeing under iOS 7.