⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@fedegiova
Copy link

For the socket-activation use case the external socket should not be shutdown() when the TServerSocket is closed.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

For the socket-activation use case the external socket should not
be shutdown() when the TServerSocket is closed.
@mergeable mergeable bot added the c++ label Jan 29, 2026
@fedegiova
Copy link
Author

Issue found during testing with a systemd socket activated service. Without the patch the journal will report:

Jan 26 12:30:10 pegasus-base-6434 systemd[1]: display-service.socket: Got POLLHUP on a listening socket. The service probably invoked shutdown() on it, and should better not do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant