⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@dossett
Copy link
Contributor

@dossett dossett commented Jan 13, 2026

After the Java 11 release, japicmp became uphappy with IndexIterator even though that file hasn't changed in years. CI checks and push checks are now failing. This change excludes the file from japicmp. An alternative would be to explicitly implement the default behavior for new methods like next() but that seems like a worse outcome.

That said, I don't fully understand japicmp so maybe excluding the file is worse.

Error message from failing checks:

Error:  Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.23.1:cmp (default) on project parquet-column: There is at least one incompatibility:
  org.apache.parquet.internal.column.columnindex.IndexIterator:METHOD_ABSTRACT_ADDED_IN_IMPLEMENTED_INTERFACE -> [Help 1]

I used codex to understand and fix this problem. I asked it for an explanation suitable for a PR description and it gave me this:

The japicmp check started failing after the Java 11 baseline because PrimitiveIterator.OfInt exposes additional interface methods/bridges in the Java 11 API surface. IndexIterator still
works at runtime (defaults cover those methods), but japicmp flags it as a source‑incompatible change since the class implements that interface and doesn’t declare those methods itself.
This is a tooling false positive driven by the JDK upgrade, not an actual behavior regression.

This change excludes org.apache.parquet.internal.column.columnindex.IndexIterator from japicmp to keep the compatibility check focused on real API changes. The exclusion aligns with prior
japicmp exceptions for JDK‑related interface‑method noise and unblocks the build without changing runtime behavior.

@dossett dossett changed the title japicmp is failing after java 11 release japicmp checks are failing after java 11 release Jan 13, 2026
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @dossett

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants