⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@Kengne-yvana
Copy link
Contributor

@Kengne-yvana Kengne-yvana commented Jan 19, 2026

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

Copy link
Contributor Author

@Kengne-yvana Kengne-yvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is to make sure FINERACT uses postgresql and MySQL when needed without breaking the code . Having the same author and path but different id. I added database-specific Liquibase contexts to ensure the correct SQL dialect is applied without affecting existing MySQL installations. This fix replaces MySQL-specific functions (WEEK, MONTHNAME) with ISO-standard functions (EXTRACT, TO_CHAR) for PostgreSQL environments, while maintaining the same author and file path for traceability.

Copy link
Contributor

@galovics galovics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the reason for changing an existing changelog file?

@Kengne-yvana
Copy link
Contributor Author

@galovics I choose to add the fix to this file because that's where my research let me to which is where the reports where updated for Mysql .

@IOhacker
Copy link
Contributor

@Kengne-yvana I think that it is better to create a new changelog file. So then the fix will be applied as a new migration.

@Kengne-yvana
Copy link
Contributor Author

@IOhacker thanks for your review
sorry for the late reply. It is due to health issues.

@IOhacker
Copy link
Contributor

@Kengne-yvana I hope you are better now. Please let me know once I can review the PR again :) Thank you

@Kengne-yvana
Copy link
Contributor Author

@IOhacker yeah, Hello i am back now . Feeling much better. also i will apply all the changes today.
Thanks

@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2436-client-trends-postgres-fix branch from 22cba44 to 8e16741 Compare January 23, 2026 13:38
@Kengne-yvana
Copy link
Contributor Author

@IOhacker please i am waiting for your review
Thanks

Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test case which tests whether the fixed reports are working as expected?

@Kengne-yvana
Copy link
Contributor Author

sure @adamsaghy

@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2436-client-trends-postgres-fix branch 2 times, most recently from 8e16741 to 7bb14ed Compare January 27, 2026 17:06
Copy link
Contributor

@IOhacker IOhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy
Copy link
Contributor

@Kengne-yvana Kindly asking you to rebase this PR!

@IOhacker
Copy link
Contributor

IOhacker commented Feb 2, 2026

@Kengne-yvana you have to resolve the conflicts doing a rebase in your local repository. Make sure to squash and commit for sending only 1 commit.

@Kengne-yvana
Copy link
Contributor Author

@IOhacker that's what i am doing now. thanks

@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2436-client-trends-postgres-fix branch 4 times, most recently from 8d2072f to 3ab43e3 Compare February 2, 2026 09:26
@adamsaghy
Copy link
Contributor

@Kengne-yvana Please review the failing checks!

@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2436-client-trends-postgres-fix branch from 3ab43e3 to 29ebc08 Compare February 2, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants