test discovery

[Garcia6l20]

• adding doctest discovery (doctest.cmake)

[Garcia6l20]

This is a cosmetic PR but results in nicer test reports

[andreasbuhr]

Wow, this is really great! I merged "integrate_all" and your proposed change and pushed it as branch "deleteme2" to see what github actions do. In all configurations, the test "multi-threaded" runs into a timeout, see https://github.com/andreasbuhr/cppcoro/runs/1248616370 . Did you also observe this? Is this easy to fix? If not, can we disable the test until we have a fix?

[Garcia6l20]

I've been lucky: https://github.com/Garcia6l20/cppcoro/runs/1252808292?check_suite_focus=true
But this test took 23.7 sec, so maybe we should set an higher timeout !

[Garcia6l20]

Do you observe this behavior on you laptop ?
I dont, so I think it might be related to BH's VMs, don't you think so ?

[Garcia6l20]

Notice we have 2 multi-threaded test,
TEST_SUITE are not (yet) handled by doctest_discover_tests

doctest/doctest#302

[andreasbuhr]

Increasing the timeout for the one test which sometimes runs into timeout sound like a good solution to me. Would you do it?

[Garcia6l20]

Yes,
I also added sanitizers in my io_service branch, it would be really helpful for everyone, but we will also have to update doctest cause the version we are using have some problems with that, and it looks like it have been resolved on current master branch.

[andreasbuhr]

Hi, oh yes, sanitizers would be cool.
Just that I understand it correctly: An update to doctest version 2.4.0 as I prepared in lewissbaker#178 would not be sufficient? Does it have to be current master branch?

[Garcia6l20]

Idk, I just know they are fixed now I'll try out this version after.

[Garcia6l20]

Looks ok : https://github.com/Garcia6l20/cppcoro/runs/1255305707

[Garcia6l20]

Well it work... hum... it fails but it works :)
I forced a leak cause we cppcoro looks leak-free :)

https://github.com/Garcia6l20/cppcoro/runs/1255719412

ubsan seems not working with coroutines
and we'll have to investigate with tsan

[andreasbuhr]

This looks really great, thank you so much.