⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@camillobruni
Copy link
Contributor

@camillobruni camillobruni commented Jan 14, 2026

  • Use plan as options bag for constructor arguments
  • Prefix "protected" instance variables with "_"
  • Rename Benchmark.preload to Benchmark._preloadEntries
  • Move iteration and worstCase count processing to the Benchmark class
  • Add files and preloadEntries getters so we can override it in GroupedBenchmark
  • Rename plan.arguments to plan.args due to "argument" being a reserved word
  • Rename WasmLegacyBenchmark to AsyncWasmLegacyBenchmark

@camillobruni camillobruni requested a review from danleh January 14, 2026 10:15
@netlify
Copy link

netlify bot commented Jan 14, 2026

Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit b7a471e
🔍 Latest deploy log https://app.netlify.com/projects/webkit-jetstream-preview/deploys/69678a96be63930008db2e1b
😎 Deploy Preview https://deploy-preview-255--webkit-jetstream-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@danleh danleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit and questions around async/isAsync.

@camillobruni camillobruni merged commit 1dbb861 into WebKit:main Jan 14, 2026
23 checks passed
@camillobruni camillobruni deleted the 2026-01-13_plan_bag branch January 14, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants