fix(ui5-multi-input): selected item is announced correctly #12321
+54
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivoplashkov
requested changes
Oct 5, 2025
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-12321--ui5-webcomponents.netlify.app |
ivoplashkov
previously requested changes
Oct 8, 2025
Contributor
ivoplashkov
left a comment
ivoplashkov
left a comment
There was a problem hiding this comment.
In my opinion, announcement List item “N” of “X” is a side effect of another enhancement and should not be announced at all. Once an item is selected, focus returns to the input field, and there should be no announcement about the list items since the list is already closed. Instead, only the tokens should be announced. Therefore, the fix should be clearing the InvisibleMessage announcement once the popover is closed.
ndeshev
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES: #12097