docs: Website upgrade and cleanup #2371
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
| color: var(--color-fd-primary); | ||
| } | ||
|
|
||
| #nd-nav { |
There was a problem hiding this comment.
@matthewlipski I removed this as it was causing z-index issues with the search bar.
Can you see if removing it causes any issues that it originally solved when you added it? (e.g. via git blame)?
|
|
||
| // suggested here: https://github.com/fuma-nama/fumadocs/issues/1095#issuecomment-2495855920 | ||
| // before highlight call | ||
| await getSingletonHighlighter({ |
There was a problem hiding this comment.
@nperez0111 I couldn't find exactly why this was necessary, seems to work fine without?
There was a problem hiding this comment.
Was around twoslash support, looks like it may have been resolved though. Just would want to check that you can still hover over a code-block's type & see the type
| light: "github-light", | ||
| dark: "github-dark", | ||
| }, | ||
| // suggested here: https://github.com/fuma-nama/fumadocs/issues/1095#issuecomment-2495855920 |
There was a problem hiding this comment.
@nperez0111 similar to above, do you remember why / where this was needed?
|
Too much code changed to meaningfully review, maybe instead you can share what your goals are with this? |
Summary
(This was done by first creating a new fumadocs project and step-by-step moving things over)
TODO:
[ ] PR review
[ ] Testing across screen sizes and light / darkmode
[ ] move react-email changes to separate PR
[ ] check if db migration is required