⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Update dependency express to v5 #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update dependency express to v5 #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/express-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
},
"devDependencies": {
"c8": "10.1.3",
"express": "4.21.1",
"express": "5.2.1",
"express-session": "1.18.1",
"mocha": "10.7.3",
"multer": "^2.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/http-stream/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
},
"devDependencies": {
"c8": "10.1.3",
"express": "4.21.1",
"express": "5.2.1",
Copy link

@cursor cursor bot Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Express v5 wildcard route syntax breaks test code

Upgrading Express from v4 to v5 breaks existing test code in packages/http-stream/test/HttpStream.test.js. The test uses app.post('*', ...) which was valid in Express v4, but Express v5's path-to-regexp v8 requires a different syntax for wildcard routes (e.g., /*splat or /{*path}). This will cause a TypeError when the tests are run, as the * character is no longer treated as a wildcard in route definitions.

Fix in Cursor Fix in Web

"mocha": "10.7.3",
"should": "13.2.3",
"sinon": "18.0.0"
Expand Down
4 changes: 2 additions & 2 deletions packages/prometheus-metrics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"build"
],
"devDependencies": {
"@types/express": "4.17.21",
"@types/express": "5.0.6",
"@types/sinon": "17.0.4",
"@types/stoppable": "1.1.3",
"@types/supertest": "6.0.3",
Expand All @@ -43,7 +43,7 @@
},
"dependencies": {
"@tryghost/logging": "^2.5.0",
"express": "4.21.2",
"express": "5.2.1",
"prom-client": "15.1.3",
"stoppable": "1.1.0"
}
Expand Down
Loading
Loading