⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@AcKoucher
Copy link
Contributor

Draft to present the general idea.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces timing-driven macro placement by integrating the Resizer module to identify critical nets. The changes consistently extend the existing simulated annealing algorithm to incorporate critical wire length into its cost function. The modifications span across various components, including the MacroPlacer initialization, CMakeLists.txt for linking, header files for new methods and members, and source files for implementation details. The Tcl interface has also been updated to expose the new timing_driven option. The changes are well-contained and appear to be functionally sound.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions


// Variables for data flow
DataFlow data_connections_;
sta::NetSeq critical_nets_;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: no header providing "sta::NetSeq" is directly included [misc-include-cleaner]

src/mpl/src/clusterEngine.h:21:

+ #include "sta/NetworkClass.hh"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants