⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

302updates #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bourgeoa merged 3 commits into from
Jan 24, 2026
Merged

302updates #670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc155ab
updates rdflib, solid-logic, pane-registry
bourgeoa Jan 24, 2026
763dd39
3.0.3
bourgeoa Jan 24, 2026
6441d92
Merge branch 'main' into 302updates
bourgeoa Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 44 additions & 11 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 3 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "solid-ui",
"version": "3.0.2",
"version": "3.0.3",
Copy link

Copilot AI Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package version is bumped as a patch release (3.0.2 → 3.0.3), but tightening peer dependency minimums can be breaking for downstream apps. If this peer range narrowing is intentional, consider whether the package version should be a minor/major bump per semver (or document the breaking requirement in release notes).

Suggested change
"version": "3.0.3",
"version": "3.1.0",

Copilot uses AI. Check for mistakes.
"description": "UI library for Solid applications",
"main": "dist/solid-ui.js",
"types": "dist/index.d.ts",
Expand Down Expand Up @@ -74,8 +74,8 @@
"uuid": "^13.0.0"
},
"peerDependencies": {
"rdflib": "^2.3.0",
"solid-logic": "^4.0.1"
"rdflib": "^2.3.5",
"solid-logic": "^4.0.2"
Comment on lines +77 to +78
Copy link

Copilot AI Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The peer dependency ranges were tightened (rdflib from ^2.3.0 to ^2.3.5, solid-logic from ^4.0.1 to ^4.0.2). This can be a breaking change for consumers pinned to the earlier patch versions. If there isn't a hard requirement on these minimum patch versions, consider keeping the previous ranges or using an explicit compatible range that still allows earlier patches.

Suggested change
"rdflib": "^2.3.5",
"solid-logic": "^4.0.2"
"rdflib": "^2.3.0",
"solid-logic": "^4.0.1"

Copilot uses AI. Check for mistakes.
},
"devDependencies": {
"@babel/cli": "^7.28.6",
Expand Down Expand Up @@ -116,11 +116,9 @@
"jsdom": "^27.4.0",
"neostandard": "^0.12.2",
"nock": "^15.0.0",
"rdflib": "^2.3.5",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react-is": "^17.0.2",
"solid-logic": "^4.0.2",
"storybook": "8.6.15",
Comment on lines 116 to 122
Copy link

Copilot AI Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rdflib and solid-logic are imported throughout src/ and test/ (e.g., many files import from these packages). Removing them from devDependencies can make npm test/npm run build fail in a fresh checkout unless the package manager installs root peerDependencies into the workspace. Consider adding them back to devDependencies (keeping them in peerDependencies for consumers) so contributors/CI can reliably install and run builds/tests.

Copilot uses AI. Check for mistakes.
"terser-webpack-plugin": "^5.3.16",
"typedoc": "^0.28.16",
Expand Down