⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

solid-ui themes foundation #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bourgeoa wants to merge 1 commit into
base: main
Choose a base branch
from
Open

solid-ui themes foundation #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"homepage": "https://github.com/solid/folder-pane",
"peerDependencies": {
"solid-logic": "^4.0.0",
"solid-ui": "^3.0.0"
"solid-ui": "^3.0.1-11be53b"
},
"devDependencies": {
"@babel/core": "^7.28.0",
Expand Down
8 changes: 4 additions & 4 deletions src/folderPane.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export default {
const defaultpropview = outliner.VIEWAS_boring_default
const tr = outliner.propertyTR(dom, st, false)
tr.firstChild.textContent = '' // Was initialized to 'Contains'
tr.firstChild.style.cssText += 'min-width: 3em;'
tr.firstChild.style.cssText += 'min-width: var(--sui-space-2xl, 3em);'
Copy link

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a spacing CSS variable (--sui-space-2xl) for a width property is semantically inconsistent. The min-width property defines a minimum dimension/size, not spacing. Consider using a size-specific variable like --sui-size-2xl or --sui-width-sm instead to maintain clear semantic separation between spacing (margins, padding, gaps) and sizing (width, height) properties in the theme system.

Suggested change
tr.firstChild.style.cssText += 'min-width: var(--sui-space-2xl, 3em);'
tr.firstChild.style.cssText += 'min-width: var(--sui-size-2xl, 3em);'

Copilot uses AI. Check for mistakes.
tr.appendChild(
outliner.outlineObjectTD(obj, defaultpropview, undefined, st)
)
Expand All @@ -79,7 +79,7 @@ export default {
let mainTable // This is a live synced table
const div = dom.createElement('div')
div.setAttribute('class', 'instancePane')
const paneStyle = UI.style.folderPaneStyle || 'border-top: solid 1px #777; border-bottom: solid 1px #777; margin-top: 0.5em; margin-bottom: 0.5em;'
const paneStyle = UI.style.folderPaneStyle || 'border-top: solid 1px var(--sui-border-color, #777); border-bottom: solid 1px var(--sui-border-color, #777); margin-top: var(--sui-space-md, 0.5em); margin-bottom: var(--sui-space-md, 0.5em);'
div.setAttribute('style', paneStyle)

const thisDir = subject.uri.endsWith('/') ? subject.uri : subject.uri + '/'
Expand All @@ -89,7 +89,7 @@ export default {
'View of folder will be view of indexThing. Loading ' + indexThing
)
const packageDiv = div.appendChild(dom.createElement('div'))
packageDiv.style.cssText = 'border-top: 0.2em solid #ccc;' // Separate folder views above from package views below
packageDiv.style.cssText = 'border-top: 0.2em solid var(--sui-border-color, #ccc);' // Separate folder views above from package views below
kb.fetcher.load(indexThing.doc()).then(function () {
mainTable = packageDiv.appendChild(dom.createElement('table'))
context
Expand Down Expand Up @@ -137,7 +137,7 @@ export default {
)
target.style.cssText = iconStyleFound
target.setAttribute('src', UI.icons.iconBase + 'noun_748003.svg')
target.setAttribute('style', 'width: 2em; height: 2em') // Safari says target.style is read-only
target.setAttribute('style', 'width: var(--sui-icon-size, 2em); height: var(--sui-icon-size, 2em);') // Safari says target.style is read-only
} else {
target = creationDiv.firstChild // Overload drop target semantics onto the plus sign
}
Expand Down
Loading