fix: id filtering crash by adding MongoDB ObjectIDs support in convertFilter function#55
Open
melifetaji wants to merge 1 commit intoSoftwareBrothers:mainfrom
Open
fix: id filtering crash by adding MongoDB ObjectIDs support in convertFilter function#55melifetaji wants to merge 1 commit intoSoftwareBrothers:mainfrom
melifetaji wants to merge 1 commit intoSoftwareBrothers:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves a runtime crash issue in the
convertFilterfunction within the adminJS-prisma adapter when filtering by MongoDB ObjectIDs. The existing implementation supported UUIDs for ID fields, but did not handle MongoDB ObjectIDs, leading to errors (panic in Prisma Query Engine). The changes introduced include:equalsoperator), ensuring compatibility and preventing crashes.