Open
Conversation
…l need to implement CurrentDictionary.
… appear to update these references when changed without restarting.
…mework and Samples are not built in the 3.5 configurations. Need to test on an 2003/XP machine.
Owner
|
I am not against this in principle, just needs careful review |
Author
|
I completely understand; if I can be of any assistance please let me know. Likewise, let me know if you notice any bugs or poor design decisions and I'll fix them. Thanks! |
|
I'm also really interested in seeing a 3.5 SKU of this project. |
Author
|
@RoryBecker As far I know, my personal fork works fine in 3.5; though I have not been keeping up with any changes to the core project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I recently discovered the MvcMiniProfiler and love it but then noticed that it is .Net 4.0 only. Here is a simple attempt to remedy that. My goal was to have as minimal an impact on the existing code as possible and thus I centralized most of the changes into the DotNet35Support.cs file.
The major changes are:
IConcurrentDictionary<TKey, TValue>interface and updated the SqlProfiler type to use it rather than the ConcurrentDictionary that is only included with .Net 4.0.MiniConcurrentDictionary<TKey, TValue>type. This type is a very simple synchronized dictionary implementation for the 3.5 version, but should suffice for the required usage. The 4.0 version is simply a subtype ofSystem.Collections.Concurrent.ConcurrentDictionary.I don't think the other changes are particularly notable and should be self-explanatory. Building a version that targets the 3.5 framework is as simple as changing the configuration to NET35-Debug or NET35-Release and building normally.
Note that I did not update the EF, LinqToSql, or sample projects to support 3.5 as that was out of the scope of my needs.
I hope this is helpful!