Add exception smoke tests, generalize PlUnknownError #104
Conversation
| % hello :- write('hello hello hello') | ||
| with_output_to(string(Out), hello). | ||
|
|
||
| test(helloex, error(unknown_error('an exception'))) :- |
There was a problem hiding this comment.
Errors should always be of the shape error(Formal, Context). That is used everywhere in the system to distinguish error exceptions from other exceptions (like timeout, abort, etc.) Typically you leave the 2nd argument unbound in SWI-Prolog. The exception handler adds the context, either as a single predicate or as a stack trace.
There was a problem hiding this comment.
There are a few other places where errors are of the wrong shape -- I'll review all the SWI-cpp2.* code and add another commit. This might break backwards compatibility, but I hope not.
If I can, I'll also make PlException's constructor inaccessible, to avoid making this mistake again.
|
I think I have a solution that helps avoid "wrong shape" error terms, but I need to think about it a bit more. If it seems to be good, I'll close this PR and create new PRs with the improvement. |
2 participants
No description provided.